Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Support for Windows Based Docker Images #134

Merged
merged 16 commits into from
Dec 21, 2021

Conversation

AndrewKahr
Copy link
Member

Changes

  • Added dockerfiles for windows-based containers
  • Added workflow files to build windows-based base, hub, and editor images, mirroring the existing system in place for ubuntu based images
  • Modified pull-request workflow file to also test windows images

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

…rkflow files to build the new windows containers to match the system in place for ubuntu images
@github-actions
Copy link

Cat Gif

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! ❤

Looking good for the most part, a things still need changing to get it into a mergeable state.

.github/workflows/new-windows-base-image-requested.yml Outdated Show resolved Hide resolved
.github/workflows/new-windows-hub-image-requested.yml Outdated Show resolved Hide resolved
.github/workflows/new-windows-hub-image-requested.yml Outdated Show resolved Hide resolved

on:
repository_dispatch:
types: [ new_2019_3_plus_editor_image_requested, new_windows_post_2019_2_editor_image_requested ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to find out whether we need pre 2019.3 builds or not.

IL2CPP for windows was introduced with 2019.3, so does that mean there's no point in building any images from before 2019.3? Or is there still some use for XBox or UWP or other platforms.

Perhaps @GabLeRoux you could also pitch in here.

images/windows/base/Dockerfile Outdated Show resolved Hide resolved
images/windows/editor/Dockerfile Outdated Show resolved Hide resolved
@webbertakken webbertakken merged commit f7dae7f into game-ci:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants